Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

che #14283: Switching all the versions from 'next' to '7.0.0-next' #206

Merged
merged 2 commits into from
Aug 20, 2019

Conversation

ibuziuk
Copy link
Member

@ibuziuk ibuziuk commented Aug 19, 2019

Signed-off-by: Ilya Buziuk ibuziuk@redhat.com

What does this PR do?

DO NOT MERGE until eclipse/che-machine-exec:7.0.0-next is released
Switching all the versions from 'next' back to '7.0.0-next' aka find . -name '*.yaml' -exec sed -i -e 's/next/7.0.0/g' {} \;
Basically, this PR reverts #203
currently next version of the plugins is not compatible with Che master.
related issues:

Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
@ibuziuk
Copy link
Member Author

ibuziuk commented Aug 19, 2019

@vparfonov for the sake of consistency can we release eclipse/che-machine-exec:7.0.0-next ? (I believe it should be the same as 7.0.0 for now)

@ibuziuk ibuziuk changed the title che #14283: Switching all the versions from 'next' to '7.0.0' che #14283: Switching all the versions from 'next' to '7.0.0-next' Aug 19, 2019
Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
@ibuziuk
Copy link
Member Author

ibuziuk commented Aug 20, 2019

@vparfonov I have also added back 7.0.0-next version of che-theia to avoid backward compatibility isssues. I believe we should never remove existing versions of plugins in master

@vparfonov
Copy link
Contributor

vparfonov commented Aug 20, 2019

@vparfonov for the sake of consistency can we release eclipse/che-machine-exec:7.0.0-next ? (I believe it should be the same as 7.0.0 for now)

what the reason use 7.0.0-next? Will be easy just set to the 7.0.0. Also in master we need to use next version as a rule

@ibuziuk
Copy link
Member Author

ibuziuk commented Aug 20, 2019

what the reason use 7.0.0-next?

For consistency since all the plugins in this PR use 7.0.0-next as a version of the runtime containers

Also in master we need to use next version as a rule

yes, but only if next version works correctly, which is not the case. Otherwise, we would face issues similar to:

@ibuziuk ibuziuk merged commit 6cb7ef3 into eclipse-che:master Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants