chore(testing): add integration test for init command #29
Conversation
| afterEach(() => { | ||
| jest.resetModules(); | ||
| }); | ||
| describe("my thing", () => { |
There was a problem hiding this comment.
should probably use something more descriptive 😂
There was a problem hiding this comment.
🤦♂️ that's embarrassing
| jest.mock("fs"); | ||
| jest.spyOn(process, "cwd").mockImplementation(() => "/custom/path/to"); | ||
|
|
||
| const { getTemplateLocation } = require("../utils/getTemplateLocation"); |
There was a problem hiding this comment.
Yes! Great question. I asked the same thing (Alvin wrote the original test).
The reason for that is this: we're spying on process.cwd(), which is used inside the getTemplateLocation function's file. By reimporting it, within the it block after we've mocked the implementation for process.cwd, the mock works as expected and the test assertion passes.
If we remove that and use the "global" import for that file, process.cwd() does not use our mock. I found this out through trial and error, and from reading these relevant Jest issues:
I will add a comment to explain that (condensed of course). Great question!
src/__tests__/init.test.ts
Outdated
| } | ||
| }); | ||
|
|
||
| it("expects to find a backup.json and package.json", async () => { |
There was a problem hiding this comment.
Should we be checking for yarn.lock to exist here as well?
There was a problem hiding this comment.
Jeffery, your eyes are impeccable - great catch - I'll add that in now
|
@all-contributors please add @jeffreyzhen for review |
|
I've put up a pull request to add @jeffreyzhen! 🎉 |
This PR adds some integration tests for the
initcommandChanges
Adds tests for the following:
initcommand works without a flaginitcommand works with a flag of a valid projectinitcommand displays an error when you pass an invalid flaginitcommand installseb-scriptsand adds a script to thepackage.jsonScreenshots
Checklist
Fixes #19