Make region required in Part 3 docs #525
Open
+1,192
−379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the XSD to match the spec, which requires that if a `layout` element is present, it must have at least one `region` child. In Part 3 the `layout` element itself is optional, but in Part 1 it is required. Also update the test XML templates to be valid: many of them had invalid empty `layout` elements. Fix the Segmenter so that if a `layout` element has no `region` children, the `layout` element itself is removed. Closes #524.
spoeschel
reviewed
Dec 4, 2019
Remove pytest-capturelog as it is now built into pytest
WIP - about half way there. Must now use `parsers.parse()` for inserted variables. This means some steps cannot be distinguished by their variable names, and need editing. Empty example values no longer get automatically translated: fix/workaround is to provide fixture definitions for the variable and match strings excluding the variable. `@given` no longer defines fixtures, but we depend on them being fixtures in a lot of places, so define `target_fixture=` explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the XSD to match the spec, which requires that if a
layoutelement is present, it must have at least oneregionchild. In Part 3 thelayoutelement itself is optional, but in Part 1 it is required.Also update the test XML templates to be valid: many of them had invalid empty
layoutelements.Fix the Segmenter so that if a
layoutelement has noregionchildren, thelayoutelement itself is removed.Closes #524.