Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 499 bdd feature files #513

Open
wants to merge 14 commits into
base: release/2.1.3
Choose a base branch
from

Conversation

nigelmegitt
Copy link
Collaborator

Add test steps to run feature files that were not previously run; closes #499.

Removes a test warning, improves twisted's ability to verify certificates.
Use relative links to templates.
Put message payload into the UIP display so that the receiver can read it without having to open the message XML up.
No longer needed because it has been merged into the core.
Track a change to proxy handling in Autobahn / twisted for #477. There's probably a more elegant way, but this works for now... Lacking a test, but have verified it locally.
We don't need the HTTPProxyConfig object at all anymore, just a `dict` will do.
Remove requirement for pytest-capturelog.

Merging now ahead of future work to convert to Python3.
User relative links to templates
Closes #490.

Calling fixtures directly is deprecated, this solution described at
https://docs.pytest.org/en/latest/deprecations.html#calling-fixtures-directly
seems to work, creating a named fixture rather than defining the "then"
step as a fixture directly.
Temporarily fixes #496, prior to addressing the problem properly anyway.
Restrict autobahn to versions before 18 - Fixes #496 and #497.
Temporarily fixes #496, prior to addressing the problem properly anyway.
Don't call fixtures directly. Closes #490, enables other work by creating an environment in which builds pass.
This test seems to make some assumptions about the code and how it computes padding values that are not true. We should look at that!
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 85.333% when pulling 77fc39f on issue-499-BDD-feature-files into fa4b6ac on release/2.1.2.

@nigelmegitt
Copy link
Collaborator Author

Currently two tests are skipped in padding.feature because the code doesn't do what the test thinks it should do. @EyalLavi I think you wrote the feature a long long time ago. If you have any recollection of the intent, that might help us decide what to do about this.

This leaves the ebuttd_segmenter.feature still not running, but I think that may have been overtaken by events - there is no ebuttd segmenter per se; instead there is a resequencer and a deduplicator and an ebuttd encoder, and they each have tests (more to come for the ebuttd encoder) so my proposal is to delete the file. Again, @EyalLavi does that sound reasonable to you?

@nigelmegitt nigelmegitt self-assigned this Oct 11, 2019
@nigelmegitt nigelmegitt changed the base branch from release/2.1.2 to release/2.1.3 December 21, 2021 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants