Issue 485 remote clock #486
Open
+134
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer needed because it has been merged into the core.
Track a change to proxy handling in Autobahn / twisted for #477. There's probably a more elegant way, but this works for now... Lacking a test, but have verified it locally.
We don't need the HTTPProxyConfig object at all anymore, just a `dict` will do.
Have seen this error a couple of times during live operation:
```Shell
Unhandled error in Deferred:
[CRITICAL] (2018-05-08 13:43:42,705) in twisted[154] - Unhandled error in Deferred:
[CRITICAL] (2018-05-08 13:43:42,705) in twisted[154] -
Traceback (most recent call last):
File "/Users/megitn02/Code/ebu/ebu-tt-live-toolkit/venv/lib/python2.7/site-packages/twisted/internet/defer.py", line 150, in maybeDeferred
result = f(*args, **kw)
File "/Users/megitn02/Code/ebu/ebu-tt-live-toolkit/ebu_tt_live/node/consumer.py", line 134, in convert_next_segment
end=self.last_segment_end + self._segment_length
File "/Users/megitn02/Code/ebu/ebu-tt-live-toolkit/ebu_tt_live/node/consumer.py", line 122, in get_segment
sequence_number=self._segment_counter
File "/Users/megitn02/Code/ebu/ebu-tt-live-toolkit/ebu_tt_live/documents/ebutt3.py", line 1004, in extract_segment
document_segments=document_segments
File "/Users/megitn02/Code/ebu/ebu-tt-live-toolkit/ebu_tt_live/documents/ebutt3_splicer.py", line 29, in __init__
self._do_splice()
File "/Users/megitn02/Code/ebu/ebu-tt-live-toolkit/ebu_tt_live/documents/ebutt3_splicer.py", line 66, in _do_splice
merged_body = merged_body.merge(current_tt.body, self._dataset)
File "/Users/megitn02/Code/ebu/ebu-tt-live-toolkit/ebu_tt_live/bindings/__init__.py", line 974, in merge
self._merge_deconflict_ids(element=other_elem, dest=merged_body, ids=ids)
File "/Users/megitn02/Code/ebu/ebu-tt-live-toolkit/ebu_tt_live/bindings/__init__.py", line 949, in _merge_deconflict_ids
cls._merge_deconflict_ids(item.value, copied_elem, ids)
File "/Users/megitn02/Code/ebu/ebu-tt-live-toolkit/ebu_tt_live/bindings/__init__.py", line 949, in _merge_deconflict_ids
cls._merge_deconflict_ids(item.value, copied_elem, ids)
File "/Users/megitn02/Code/ebu/ebu-tt-live-toolkit/ebu_tt_live/bindings/__init__.py", line 949, in _merge_deconflict_ids
cls._merge_deconflict_ids(item.value, copied_elem, ids)
File "/Users/megitn02/Code/ebu/ebu-tt-live-toolkit/ebu_tt_live/bindings/__init__.py", line 942, in _merge_deconflict_ids
log.debug('processing child: {} of {}'.format(item.value, element))
UnicodeEncodeError: 'ascii' codec can't encode character u'\xa3' in position 1: ordinal not in range(128)
```
So commenting out that line. No idea how that character can appear in the relevant line, it's a £ sign.
Simplest fix for #481
This strips out unencodable characters and if not fixes, at least masks #483 by using `codecs.open` and telling it to ignore errors.
Part of the fix for #481 - allow the filesystem output carriage begin count to be overridden in the ebuttd-encoder using a first document datetime and a document duration. The zeroth document is calculated as the difference between the current datetime and the specified datetime divided by the document duration.
Add config options documentation for `override_begin_count` and `begin_count`.
timezone is ignored, with warning if present and not Z, since UTC is assumed.
Pass a URL through if one is provided. Fix a problem where the wrong media time was being used when the zero time was being set - needs to be based on a date as well as a time.
If a URL is provided for the clock, make a remote request to get it and process the string, and use it to adjust the media clock.
Form media_time_zero format and for clock url.
The times are provided by the input `real_clock_timedelta`. Fixes a big offset issue.
|
I've just re-reviewed this. Some thoughts:
Conclusion: more work needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #485 by allowing a remote URL to be provided, which is dereferenced and the returned ISO date processed and used.