No aliases for containers #74
Open
+4,860
−3,409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix parser inlude types remove types for arr and opt fix seq and opt debugging tests fix fixtures remove debug minor fixes fix deduplicator remove unnecessary fixes update validation and form fixtures update test data fixture update recursive type generation fix recursive container update tests fixture update fixtures update fixtures fix controller types fix controllers fix fixtures Rename methods and add a test for TypeAnalyzer Move Field back change test split replaceType code style Fix replaceContainerType Fix echo test Fxi parameters, types. Update tests update core test results Fix flattener, update fixtures Fix validation Fix enums Remove duplicated code Fix writable_name added test cleanup fix typo update tests update tests
s12v
commented
Mar 25, 2017
| @@ -11,7 +11,7 @@ package yaml { | |||
| def petType: String | |||
| } | |||
|
|
|||
| case class Zoo(tiers: ZooTiers) | |||
| case class Zoo(tiers: Option[Seq[Pet]]) | |||
There was a problem hiding this comment.
should probably be Option[Seq[IPet]]
| def generator(r: Reference, table: DenotationTable): String = | ||
| append(typeNameDenotation(table, r), generatorsSuffix) | ||
| def generator(r: Reference, table: DenotationTable): String = { | ||
| val name = typeNameDenotation(table, r).replace("[", "").replace("]", "") |
There was a problem hiding this comment.
replaceAll("""[\[\]]""", "") might be better than two calls to replace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #58
Replaces
type PetId = Option[Long]withOption[Long]. The change turned out to be not so simple and triggered chain reaction of changes in deduplicator and generators :)Work in progress. Please check.
TODO: