Implement pull-based diagnostic requests #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version includes missing requests, types, and other changes needed for full LSP 3.17.0 compatibility.
This commit implements the following new requests: * textDocument/diagnostic (client-to-server) * workspace/diagnostic (client-to-server) * workspace/diagnostic/refresh (server-to-client)
The upcomnig version of the LSP specification is now 3.18. Version 3.17 was stabilized long ago.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
textDocument/diagnosticserver request.workspace/diagnosticserver request.workspace/diagnostic/refreshclient request.Changed
lsp-types0.94.1.Fixed
LanguageServer::completion()method.README.md.This pull request upgrades our
lsp-typesversion in response to gluon-lang/lsp-types#258 finally getting merged upstream. It also bringstower-lspup to full compliance with LSP version 3.17.0, at last. 🎉 At least, technically minus notebook support, which appears to be an incredibly niche feature at the time of writing.Closes #374.