model_parameters.anova() includes df_error (#988)

* `model_parameters.anova()` includes `df_error` easystats/report#453 * add test
easystats · Jul 9, 2024 · cc8a236 · cc8a236
1 parent d9d2455
commit cc8a236
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 3 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Type: Package
 Package: parameters
 Title: Processing of Model Parameters
-Version: 0.22.0.1
+Version: 0.22.0.2
 Authors@R:
     c(person(given = "Daniel",
              family = "Lüdecke",

diff --git a/NEWS.md b/NEWS.md
@@ -4,6 +4,11 @@
 
 * Support for `svy2lme` models from package *svylme*.
 
+## Bug fixes
+
+* `model_parameters()` for `anova()` from mixed models now also includes the
+  denominator degrees of freedom in the output (`df_error`).
+
 # parameters 0.22.0
 
 ## Breaking changes
@@ -199,7 +204,7 @@
 
 * `as.data.frame` methods for extracting posterior draws via `bootstrap_model()`
   have been retired. Instead, directly using `bootstrap_model()` is recommended.
-  
+
 ## Changes to functions
 
 * `equivalence_test()` gets a method for `ggeffects` objects from package
@@ -351,7 +356,7 @@
 * Following functions were moved from package *parameters* to *performance*:
   `check_sphericity_bartlett()`, `check_kmo()`, `check_factorstructure()` and
   `check_clusterstructure()`.
-  
+
 ## Changes to functions
 
 * Added `sparse` option to `principal_components()` for sparse PCA.

diff --git a/R/extract_parameters_anova.R b/R/extract_parameters_anova.R
@@ -49,6 +49,7 @@
   names(parameters) <- gsub("Resid. Dev", "Deviance_error", names(parameters), fixed = TRUE)
   # error-df
   if (!"df_error" %in% names(parameters)) {
+    names(parameters) <- gsub("DenDF", "df_error", names(parameters), fixed = TRUE)
     names(parameters) <- gsub("den Df", "df_error", names(parameters), fixed = TRUE)
     names(parameters) <- gsub("Res.Df", "df_error", names(parameters), fixed = TRUE)
     names(parameters) <- gsub("Resid. Df", "df_error", names(parameters), fixed = TRUE)

diff --git a/tests/testthat/test-model_parameters.anova.R b/tests/testthat/test-model_parameters.anova.R
@@ -22,6 +22,15 @@ test_that("model_parameters.anova", {
   expect_equal(mp[["F"]], c(53.40138, 60.42944, 13.96887, NA), tolerance = 1e-3)
 })
 
+test_that("model_parameters.anova for mixed models", {
+  skip_if_not_installed("lme4")
+  skip_if_not_installed("lmerTest")
+  m <- lmerTest::lmer(mpg ~ wt + (1 | gear), data = mtcars)
+  out <- parameters::model_parameters(anova(m))
+  expect_named(out, c("Parameter", "Sum_Squares", "df", "df_error", "Mean_Square", "F", "p"))
+  expect_equal(out$df_error, 21.92272, tolerance = 1e-4)
+})
+
 test_that("linear hypothesis tests", {
   skip_if_not_installed("car")
   skip_if_not_installed("carData")