Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optim egctl get httpserver to show port and https #1248

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

suchen-sci
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.50%. Comparing base (f9117fa) to head (0c61721).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1248      +/-   ##
==========================================
+ Coverage   79.48%   79.50%   +0.01%     
==========================================
  Files         152      152              
  Lines       17295    17295              
==========================================
+ Hits        13747    13750       +3     
+ Misses       2879     2877       -2     
+ Partials      669      668       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

for namespace, metas := range metas {
if namespace == DefaultNamespace {
continue
}
for _, meta := range metas {
table = append(table, []string{meta.Name, meta.Kind, namespace, getAgeFromMetaSpec(meta)})
if meta.Kind == "HTTPServer" {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is common for each object to have its representation, so a well-designed framework is needed to handle the difference.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated, please check

@suchen-sci suchen-sci marked this pull request as draft March 26, 2024 09:04
@suchen-sci suchen-sci marked this pull request as ready for review March 26, 2024 09:08
@suchen-sci suchen-sci marked this pull request as draft March 26, 2024 09:24
@suchen-sci suchen-sci marked this pull request as ready for review March 26, 2024 10:11
}

// ObjectSpec is the interface of the object spec.
type ObjectSpec interface {
Copy link
Collaborator

@zhao-kun zhao-kun Mar 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's best to give a meaningful name to intuitively describe its usage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants