Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat#86 credentials #89

Merged
merged 19 commits into from
Jul 22, 2024
Merged

Feat#86 credentials #89

merged 19 commits into from
Jul 22, 2024

Conversation

rle-earthdaily
Copy link
Collaborator

Add various credentials loading methods in the Auth class, all centralized in the Auth.from_credentials method, which is then called by the earthdaily.earthdatastore.EarthDataStore function. The idea is to stop users from importing the Auth class directly and propose a consistent and simple way of loading credentials.

A few notable points:

  • No breaking change, but a deprecation warning for people that use the Auth constructor to load credentials from a JSON file
  • The new authentification methods are tested in tests/test_auth.py
  • Examples now use the new EarthDataStore function
  • Unit tests now use the new EarthDataStore function
  • Remove the Venus example, after a discussion with @nkarasiak
  • More information in the README for credentials handling

@nkarasiak nkarasiak changed the base branch from main to dev July 5, 2024 12:09
nicolasK and others added 2 commits July 22, 2024 09:40
fix to work when rescale asset has extension
@nkarasiak
Copy link
Collaborator

What a great commit ! I merge it on dev.
We need to talk a bit about the copy-credentials-template before merging to main.

@nkarasiak nkarasiak merged commit f2b9016 into dev Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants