patch(metro-runtime): Add cycle resolution support to require #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealush
changed the title
ealush
force-pushed
the
2022-12-14-resolving-cycles
branch
2 times, most recently
from
bccbfa7
to
7c9db0f
Compare
ealush
force-pushed
the
2022-12-14-resolving-cycles
branch
from
7c9db0f
to
0d1061d
Compare
ealush
force-pushed
the
2022-12-14-resolving-cycles
branch
from
c651d8e
to
19d7611
Compare
ealush
force-pushed
the
2022-12-14-resolving-cycles
branch
from
7529dab
to
f6560e3
Compare
ealush
force-pushed
the
2022-12-14-resolving-cycles
branch
4 times, most recently
from
82b8811
to
a5e8545
Compare
ealush
changed the title
ealush
force-pushed
the
2022-12-14-resolving-cycles
branch
from
a5e8545
to
0fb2d87
Compare
ealush
commented
Dec 19, 2022
| didBailOut = true; | ||
| return []; | ||
|
|
||
| const {updatedModuleIDs, cycles} = topologicalSort( |
There was a problem hiding this comment.
The main change to this function is the explicit return of the updatedModuleIDs and the cycles Set.
ealush
force-pushed
the
2022-12-14-resolving-cycles
branch
from
0fb2d87
to
bbdc97f
Compare
ealush
force-pushed
the
2022-12-14-resolving-cycles
branch
from
bbdc97f
to
87c43d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.