Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indent / lint all listing during build #431

Closed
duncdrum opened this issue Jan 27, 2020 · 1 comment
Closed

indent / lint all listing during build #431

duncdrum opened this issue Jan 27, 2020 · 1 comment
Assignees
Milestone

Comments

@duncdrum
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently listings ending in .xml are not linted in a uniform manner, which can make them harder to read. This is due to the individual settings that different contributors have locally when creating PRs.

Describe the solution you'd like
Lint/ Beautify all listings during build so that we get a more uniform appearance.

Describe alternatives you've considered
Prescribe via author-reference but that would just increase the work for reviewers.

@duncdrum duncdrum self-assigned this Jan 27, 2020
@duncdrum
Copy link
Contributor Author

duncdrum commented Jan 29, 2020

apparently there is a bug with repeated runs of the linter see vkiryukhin/pretty-data#11 although we are minifying first, i see the same growth in empty lines, not good.

https://github.com/t1st3/gulp-muxml

duncdrum added a commit to duncdrum/documentation that referenced this issue Jan 29, 2020
duncdrum added a commit to duncdrum/documentation that referenced this issue Jan 29, 2020
duncdrum added a commit to duncdrum/documentation that referenced this issue Jan 29, 2020
@duncdrum duncdrum added this to the 5.2.0 milestone Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant