Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20650] Examples refactor: Delivery mechanisms #4959

Merged
merged 25 commits into from
Jun 27, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Jun 17, 2024

Description

This PR is part of a suite of PR which would make a refactor in the repository examples.
It is intended to apply to most of the examples, by making them homogeneous, more understandable, and more specific to the case they were meant to be.

In this delivery mechanisms example, the key changes are:

  • loans and data-sharing compatible: bounded types, final extensibility.
  • use loans mechanism for data management
  • add an option to select all delivery mechanisms

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added this to the v3.0.0 milestone Jun 17, 2024
@JesusPoderoso JesusPoderoso self-assigned this Jun 17, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Jun 17, 2024
@JesusPoderoso JesusPoderoso force-pushed the feature/example_refactor/delivery_mechanism branch from d77ce12 to b4a0d47 Compare June 18, 2024 08:39
@JesusPoderoso JesusPoderoso requested review from elianalf and removed request for elianalf June 18, 2024 08:40
@JesusPoderoso JesusPoderoso force-pushed the feature/example_refactor/delivery_mechanism branch from 085fbd2 to 5edd104 Compare June 18, 2024 12:27
@JesusPoderoso JesusPoderoso requested review from elianalf and removed request for elianalf June 18, 2024 12:27
@JesusPoderoso JesusPoderoso force-pushed the feature/example_refactor/delivery_mechanism branch from 5edd104 to f504155 Compare June 19, 2024 09:54
@JesusPoderoso JesusPoderoso requested review from elianalf and richiprosima and removed request for elianalf June 19, 2024 09:58
@JesusPoderoso JesusPoderoso force-pushed the feature/example_refactor/delivery_mechanism branch from c52f9eb to 22cc515 Compare June 19, 2024 10:40
@JesusPoderoso JesusPoderoso requested review from richiprosima and removed request for richiprosima June 19, 2024 10:40
@JesusPoderoso JesusPoderoso force-pushed the feature/example_refactor/delivery_mechanism branch from 22cc515 to 9373acb Compare June 19, 2024 11:04
@JesusPoderoso JesusPoderoso requested review from richiprosima and removed request for richiprosima June 19, 2024 11:04
@JesusPoderoso JesusPoderoso force-pushed the feature/example_refactor/delivery_mechanism branch from 9373acb to 9df94dd Compare June 19, 2024 11:40
@JesusPoderoso JesusPoderoso requested review from richiprosima and removed request for richiprosima June 19, 2024 11:41
@JesusPoderoso JesusPoderoso force-pushed the feature/example_refactor/delivery_mechanism branch from 9df94dd to f1a3e24 Compare June 19, 2024 13:04
@JesusPoderoso JesusPoderoso requested review from richiprosima and removed request for richiprosima June 19, 2024 13:04
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
…eally stopped

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
…s gen

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso force-pushed the feature/example_refactor/delivery_mechanism branch from 6d97d1f to 60c624b Compare June 27, 2024 07:20
@elianalf elianalf added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jun 27, 2024
@EduPonz EduPonz merged commit 4c9f1d6 into master Jun 27, 2024
15 of 17 checks passed
@EduPonz EduPonz deleted the feature/example_refactor/delivery_mechanism branch June 27, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants