Prefetching #1842
Merged
Prefetching #1842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
richardebeling
force-pushed
the
prefetching
branch
from
8af2114
to
306c05d
Compare
richardebeling
commented
Dec 30, 2022
richardebeling
force-pushed
the
prefetching
branch
from
b6b1503
to
2ffdac4
Compare
|
Looks good, except for the last comment that blocks it |
richardebeling
force-pushed
the
prefetching
branch
from
2ffdac4
to
0a414f8
Compare
richardebeling
force-pushed
the
prefetching
branch
from
0a414f8
to
c856730
Compare
richardebeling
force-pushed
the
prefetching
branch
from
c856730
to
164218d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through the pages and fixed some N+1 query patterns we had.
Throughout the commits I changed a bit of stuff with the
is_m2m_prefetchedmethod. I ended up just making itis_prefetchedand handle both m2m as well as foreign key fields (forward and backward lookup). A given attribute on a model can only refer to a single field type, so it doesn't add much to have separateis_prefetchedmethods.