Importer performance #1841
Merged
Importer performance #1841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardebeling
force-pushed
the
1840-importer-performance-fix
branch
from
0fd6c2a
to
5f339e8
Compare
richardebeling
commented
Dec 30, 2022
richardebeling
commented
Dec 30, 2022
Merged
richardebeling
force-pushed
the
1840-importer-performance-fix
branch
2 times, most recently
from
333b4d2
to
e61b2b1
Compare
|
moving the staff semester page N+1 query fix to #1842 |
richardebeling
force-pushed
the
1840-importer-performance-fix
branch
from
0e17c4c
to
fb4b199
Compare
richardebeling
force-pushed
the
1840-importer-performance-fix
branch
from
fb4b199
to
c47a49a
Compare
niklasmohrin
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best reviewed by commit. Fixes #1840.
Openpyxl no longer spends half a minute on determining the worksheet dimensions.
We prevent some N+1 query behavior, making the importer and the staff semester page (which the importer redirects to) a bit faster.
On my machine, import times for a 6000 row sheet go from 32-40s to 3-6s.