🐛 Changed dbt packages in requirements.txt #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rafalz13
approved these changes
Mar 1, 2024
Rafalz13
reviewed
Mar 26, 2024
CHANGELOG.md
Outdated
| @@ -8,9 +8,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| ### Added | |||
|
|
|||
| ### Fixed | |||
| - Changed requirements.txt to level up version of dbt-sqlserver in order to fix bug with `MAXRECURSION` error in dbt_run | |||
There was a problem hiding this comment.
Suggested change
| - Changed requirements.txt to level up version of dbt-sqlserver in order to fix bug with `MAXRECURSION` error in dbt_run | |
| - Changed `requirements.tx`t to level up version of `dbt-sqlserver` in order to fix bug with `MAXRECURSION` error in dbt_run. |
CHANGELOG.md
Outdated
|
|
||
| ### Changed | ||
|
|
||
| ### Removed | ||
| - Removed dbt-core==1.3.2 from requirements.txt |
There was a problem hiding this comment.
Suggested change
| - Removed dbt-core==1.3.2 from requirements.txt | |
| - Removed `dbt-core==1.3.2` from `requirements.txt`. |
Rafalz13
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The PR containing changes in requirements.txt file. Dbt-sqlserver were upgraded to djagoda's fork in order to fix bug in dbt.
Importance
It is important because without it some of the Transform&Catalog flows will be failing on Prefect due to bug in current version of dbt-sqlserver. Linked issue: #854
Checklist
This PR:
CONTRIBUTING.mdCHANGELOG.md