Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharepoint list to csv #823

Merged
merged 8 commits into from
Dec 5, 2023
Merged

Sharepoint list to csv #823

merged 8 commits into from
Dec 5, 2023

Conversation

cgildenia
Copy link
Contributor

Summary

  • Merged path and adls_file_name arguments into file_name in SharepointListToADLS class.
  • Added to_csv functionality to SharepointListToADLS.

Checklist

This PR:

  • follows the guidelines laid out in CONTRIBUTING.md
  • links relevant issue(s)
  • adds/updates tests (if appropriate)
  • adds/updates docstrings (if appropriate)
  • adds an entry in CHANGELOG.md

burzekj
burzekj reviewed Nov 30, 2023
View reviewed changes
viadot/flows/sharepoint_to_adls.py Outdated Show resolved Hide resolved
viadot/flows/sharepoint_to_adls.py Show resolved Hide resolved
Rafalz13
Rafalz13 reviewed Nov 30, 2023
View reviewed changes
Copy link
Contributor

@Rafalz13 Rafalz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good. Please check tests for that and add if possible as we have new options for connector and output.

marcinpurtak
marcinpurtak requested changes Dec 4, 2023
View reviewed changes
viadot/flows/sharepoint_to_adls.py Outdated Show resolved Hide resolved
marcinpurtak
marcinpurtak approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@marcinpurtak marcinpurtak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@Rafalz13 Rafalz13 merged commit 1e57011 into dyvenia:dev Dec 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcinpurtak marcinpurtak marcinpurtak approved these changes

@Rafalz13 Rafalz13 Rafalz13 approved these changes

@burzekj burzekj burzekj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cgildenia @marcinpurtak @Rafalz13 @burzekj