Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ new logic to extracting users from genesys #811

Merged
merged 7 commits into from
Nov 15, 2023

Conversation

burzekj
Copy link
Contributor

@burzekj burzekj commented Nov 14, 2023

Summary

Added new logic to "GET" method for genesys API to extract information about genesys client users

Importance

Crucial for CEE Phase 3 tasks

Checklist

This PR:

  • follows the guidelines laid out in CONTRIBUTING.md
  • links relevant issue(s)
  • adds/updates tests (if appropriate)
  • adds/updates docstrings (if appropriate)
  • adds an entry in CHANGELOG.md

Copy link
Contributor

@Rafalz13 Rafalz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tests for new piece of code.

viadot/tasks/genesys.py Show resolved Hide resolved
viadot/tasks/genesys.py Show resolved Hide resolved
viadot/tasks/genesys.py Outdated Show resolved Hide resolved
burzekj and others added 2 commits November 15, 2023 09:25
Co-authored-by: Rafał Ziemianek <49795849+Rafalz13@users.noreply.github.com>
@burzekj
Copy link
Contributor Author

burzekj commented Nov 15, 2023

Add tests for new piece of code.

Added in commit
✅ Added test

viadot/task_utils.py Outdated Show resolved Hide resolved
viadot/task_utils.py Outdated Show resolved Hide resolved
viadot/task_utils.py Outdated Show resolved Hide resolved
viadot/tasks/genesys.py Show resolved Hide resolved
@Rafalz13 Rafalz13 merged commit dd95ceb into dyvenia:dev Nov 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants