Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Genesys agent interaction view type #803

Merged
merged 4 commits into from
Nov 13, 2023

Conversation

Diego-H-S
Copy link
Contributor

Summary

Simply added the new view type agent_interaction_view_type into genesys source code.

Importance

Required by client.

Checklist

This PR:

  • follows the guidelines laid out in CONTRIBUTING.md
  • links relevant issue(s)
  • adds/updates tests (if appropriate)
  • adds/updates docstrings (if appropriate)
  • adds an entry in CHANGELOG.md

@Diego-H-S Diego-H-S requested a review from m-paz November 8, 2023 12:24
Copy link
Contributor

@Rafalz13 Rafalz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Added 2 comments.


from viadot.task_utils import *
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this line is added here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because if I try to call it directly a circle import failure raises. Actually, I didn't introduce it, it was made by Angelika when the new data frame check was added.

@@ -322,6 +322,7 @@ def download_all_reporting_exports(
"queue_performance_detail_view",
"queue_interaction_detail_view",
"agent_status_detail_view",
"agent_interaction_detail_view",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not connected but please correct typos in line 247: Al reports were successfully dowonload -> Al and dowonload

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated!

@Rafalz13 Rafalz13 merged commit 1d9c984 into dyvenia:dev Nov 13, 2023
3 checks passed
@Diego-H-S Diego-H-S deleted the genesys_agent_interaction branch June 7, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants