-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Genesys agent interaction view type #803
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Added 2 comments.
|
||
from viadot.task_utils import * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this line is added here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because if I try to call it directly a circle import failure raises. Actually, I didn't introduce it, it was made by Angelika when the new data frame check was added.
@@ -322,6 +322,7 @@ def download_all_reporting_exports( | |||
"queue_performance_detail_view", | |||
"queue_interaction_detail_view", | |||
"agent_status_detail_view", | |||
"agent_interaction_detail_view", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not connected but please correct typos in line 247: Al reports were successfully dowonload
-> Al
and dowonload
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated!
Summary
Simply added the new view type
agent_interaction_view_type
intogenesys
source code.Importance
Required by client.
Checklist
This PR:
CONTRIBUTING.md
CHANGELOG.md