Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Genesys all queues together #691

Merged
merged 35 commits into from
Jun 13, 2023
Merged

Genesys all queues together #691

merged 35 commits into from
Jun 13, 2023

Conversation

Diego-H-S
Copy link
Contributor

Summary

In order to be more general when calling Genesys API, we have changed the method genesys_generate_exports and renamed it as genesys_api_connection introducing a new parameter end_point. Also, it has been added a method parameter to choose between wither connections, POST or GET.
It has been removed old methods never used in production but as a testing concept in the very early beginning of the actual project.
Furthermore, some parts of the calls have been modified, adding some time sleep step, to not overwhelm Genesys API, otherwise, we get fewer responses than calls made.

Importance

Required by the client to retrieve all queues from Genesys at once. The actual paradigm creates one call per queue.

Checklist

This PR:

  • adds new tests (if appropriate)
  • updates docstrings for any new functions or function arguments (if appropriate)
  • updates CHANGELOG.md with a summary of the changes

@Diego-H-S Diego-H-S requested a review from Rafalz13 May 18, 2023 07:41
Rafalz13
Rafalz13 reviewed Jun 5, 2023
View reviewed changes
Copy link
Contributor

@Rafalz13 Rafalz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the Changelog file and your branch version.

CHANGELOG.md Show resolved Hide resolved
viadot/sources/genesys.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Diego-H-S
Diego-H-S commented Jun 6, 2023
View reviewed changes
Copy link
Contributor Author

@Diego-H-S Diego-H-S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added all the comments :)

Diego-H-S
Diego-H-S commented Jun 6, 2023
View reviewed changes
Copy link
Contributor Author

@Diego-H-S Diego-H-S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all corrections added.

CHANGELOG.md Show resolved Hide resolved
Rafalz13
Rafalz13 reviewed Jun 7, 2023
View reviewed changes
Copy link
Contributor

@Rafalz13 Rafalz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

viadot/sources/genesys.py Outdated Show resolved Hide resolved
@Diego-H-S Diego-H-S requested a review from Rafalz13 June 9, 2023 07:01
@Rafalz13 Rafalz13 merged commit 1e16f4d into dyvenia:dev Jun 13, 2023
Rafalz13 added a commit that referenced this pull request Jun 14, 2023
@Rafalz13
Revert "Merge pull request #691 from Diego-H-S/genesys_all_queues_tog…
9aca931 
…ether"

This reverts commit 1e16f4d, reversing
changes made to 75e7a95.
@Diego-H-S Diego-H-S deleted the genesys_all_queues_together branch June 7, 2024 08:03
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rafalz13 Rafalz13 Rafalz13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Diego-H-S @Rafalz13 @angelika233