Merge pull request #890 from adrian-wojcik/sap_rfc_local_config_to_ke…

…y_voult_change 🐛 Fix bug related to logger.warning and tests in sap_rfc source
dyvenia · Apr 10, 2024 · b2d8a76 · b2d8a76
2 parents bb4c4d5 + c445782
commit b2d8a76
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 11 deletions.
diff --git a/tests/integration/tasks/test_sap_rfc_to_df.py b/tests/integration/tasks/test_sap_rfc_to_df.py
@@ -22,7 +22,7 @@ def test_sap_rfc_to_df_wrong_sap_credential_key_bbp(caplog):
     )
     with pytest.raises(
         CredentialError,
-        match="Sap_credentials_key: SAP_test is not stored neither in KeyVault or Local Config!",
+        match="sap_credentials_key: SAP_test is not stored neither in KeyVault or local config!",
     ):
         task.run(
             sap_credentials_key="SAP_test",

diff --git a/tests/integration/test_sap_rfc.py b/tests/integration/test_sap_rfc.py
@@ -195,15 +195,15 @@ def test___build_pandas_filter_query_v2():
 def test_default_credentials_warning_SAPRFC(caplog):
     _ = SAPRFC()
     assert (
-        f"Your credentials will use DEV environment from local config. If you would like to use different one - please specified it in sap_credentials parameter"
+        f"Your credentials will use DEV environment from local config. If you would like to use different one - please specified it in env parameter"
         in caplog.text
     )
 
 
 def test_default_credentials_warning_SAPRFCV2(caplog):
     _ = SAPRFCV2()
     assert (
-        f"Your credentials will use DEV environment from local config. If you would like to use different one - please specified it in sap_credentials parameter"
+        f"Your credentials will use DEV environment from local config. If you would like to use different one - please specified it in env parameter"
         in caplog.text
     )
 
@@ -222,7 +222,7 @@ def test_credentials_dictionary_wrong_key_warning_SAPRFC(caplog):
         in caplog.text
     )
     assert (
-        f"Your credentials will use DEV environment from local config. If you would like to use different one - please specified it in sap_credentials parameter"
+        f"Your credentials will use DEV environment from local config. If you would like to use different one - please specified it in env parameter"
         in caplog.text
     )
 
@@ -241,15 +241,15 @@ def test_credentials_dictionary_wrong_key_warning_SAPRFCV2(caplog):
         in caplog.text
     )
     assert (
-        f"Your credentials will use DEV environment from local config. If you would like to use different one - please specified it in sap_credentials parameter"
+        f"Your credentials will use DEV environment from local config. If you would like to use different one - please specified it in env parameter"
         in caplog.text
     )
 
 
 def test_sap_credentials_key_wrong_value_error_SAPRFC(caplog):
     with pytest.raises(
         CredentialError,
-        match="Sap_credentials_key: SAP_test is not stored neither in KeyVault or Local Config!",
+        match="sap_credentials_key: SAP_test is not stored neither in KeyVault or local config!",
     ):
         with caplog.at_level(logging.ERROR):
             _ = SAPRFC(sap_credentials_key="SAP_test")
@@ -258,7 +258,7 @@ def test_sap_credentials_key_wrong_value_error_SAPRFC(caplog):
 def test_sap_credentials_key_wrong_value_error_SAPRFCV2(caplog):
     with pytest.raises(
         CredentialError,
-        match="Sap_credentials_key: SAP_test is not stored neither in KeyVault or Local Config!",
+        match="sap_credentials_key: SAP_test is not stored neither in KeyVault or local config!",
     ):
         with caplog.at_level(logging.ERROR):
             _ = SAPRFC(sap_credentials_key="SAP_test")

diff --git a/viadot/sources/sap_rfc.py b/viadot/sources/sap_rfc.py
@@ -277,13 +277,13 @@ def __init__(
 
         if sap_credentials is None:
             logger.warning(
-                f"Your credentials will use {env} environment from local config. If you would like to use different one - please specified it in sap_credentials parameter."
+                f"Your credentials will use {env} environment from local config. If you would like to use different one - please specified it in env parameter."
             )
             try:
                 sap_credentials = local_config.get(sap_credentials_key).get(env)
             except AttributeError:
                 raise CredentialError(
-                    f"sap_credentials_key: {sap_credentials_key} is not stored neither in KeyVault or Local Config!"
+                    f"sap_credentials_key: {sap_credentials_key} is not stored neither in KeyVault or local config!"
                 )
             if sap_credentials is None:
                 raise CredentialError(f"Missing {env} credentials!")
@@ -747,13 +747,13 @@ def __init__(
 
         if sap_credentials is None:
             logger.warning(
-                f"Your credentials will use {env} environment from local config. If you would like to use different one - please specified it in sap_credentials parameter."
+                f"Your credentials will use {env} environment from local config. If you would like to use different one - please specified it in env parameter."
             )
             try:
                 sap_credentials = local_config.get(sap_credentials_key).get(env)
             except AttributeError:
                 raise CredentialError(
-                    f"sap_credentials_key: {sap_credentials_key} is not stored neither in KeyVault or Local Config!"
+                    f"sap_credentials_key: {sap_credentials_key} is not stored neither in KeyVault or local config!"
                 )
             if sap_credentials is None:
                 raise CredentialError(f"Missing {env} credentials!")