Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(test): Add unit tests for golang/internal/mapper #302

Merged
merged 2 commits into from
Oct 31, 2022
Merged

refactor(test): Add unit tests for golang/internal/mapper #302

merged 2 commits into from
Oct 31, 2022

Conversation

clebs
Copy link
Contributor

@clebs clebs commented Oct 26, 2022 •
edited
Loading

Part of #241

@clebs clebs requested a review from a team as a code owner October 26, 2022 11:17
@clebs clebs force-pushed the refactor/test-golang-mapper branch from 50a95b5 to 6d62de5 Compare October 26, 2022 12:58
@polaroi8d polaroi8d added issue:improvement Issue that makes something better. source:agent The scope of the issue or pull request is agent. pr:refactor lang:golang severity:low labels Oct 26, 2022
@polaroi8d polaroi8d linked an issue Oct 26, 2022 that may be closed by this pull request
Write unit tests for agent and we'll send you an awesome dyrectorio swag cap #241
Closed
@m8vago
Copy link
Contributor

m8vago commented Oct 27, 2022

Awesome! Thank you for the contribution. 👍

@clebs clebs force-pushed the refactor/test-golang-mapper branch 2 times, most recently from d8bb770 to a35a6b9 Compare October 27, 2022 21:15
@clebs
Copy link
Contributor Author

clebs commented Oct 27, 2022 •
edited
Loading

Fixed the test after a major refactor of the container data structures 15h ago. PTAL.

@clebs clebs force-pushed the refactor/test-golang-mapper branch 2 times, most recently from d536827 to ef0d250 Compare October 28, 2022 12:24
@clebs clebs force-pushed the refactor/test-golang-mapper branch from ef0d250 to af23e6c Compare October 28, 2022 12:25
@polaroi8d polaroi8d merged commit 9258bb2 into dyrector-io:develop Oct 31, 2022
@clebs clebs deleted the refactor/test-golang-mapper branch October 31, 2022 16:25
balanceee pushed a commit that referenced this pull request Nov 2, 2022
@clebs @balanceee
refactor(test): Add unit tests for golang/internal/mapper (#302)
d5442d9 
* refactor(test): Add unit tests for golang/internal/mapper

* refactor(test): Fix tests after rebase
balanceee pushed a commit that referenced this pull request Nov 2, 2022
@clebs @balanceee
refactor(test): Add unit tests for golang/internal/mapper (#302)
02b64b2 
* refactor(test): Add unit tests for golang/internal/mapper

* refactor(test): Fix tests after rebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m8vago m8vago m8vago approved these changes

@polaroi8d polaroi8d polaroi8d approved these changes

Assignees
No one assigned
Labels
issue:improvement Issue that makes something better. lang:golang pr:refactor severity:low source:agent The scope of the issue or pull request is agent.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write unit tests for agent and we'll send you an awesome dyrectorio swag cap
3 participants
@clebs @m8vago @polaroi8d