Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add container config page #297

Merged
merged 16 commits into from
Oct 27, 2022
Merged

feat: add container config page #297

merged 16 commits into from
Oct 27, 2022

Conversation

balanceee
Copy link
Contributor

@balanceee balanceee commented Oct 24, 2022 •
edited
Loading

The contains the following:

  • Added a new page to edit container/image config
  • Removed the InstanceContainerConfig/CompleteContainerConfig/ExplicitContainerConfig
  • Extracted the config field in the database. (ContainerConfig, InstanceContainerConfig).
  • Reworked the SecretKeyInputField. It is no secret specific anymore.

Szilveszter Liszy and others added 12 commits September 28, 2022 10:07
feat(cli): check docker (and podman) requirements (#197)
3abf3bf
@peterambrus3
feat(crux-ui): prettier format on windows (#215)
c2816d0 
command 'format' not working on windows
use npm run format:win32
@peterambrus3
feat(web): handle different registry namespace (#201)
905e057 
refactor(web): pr suggestions
@balanceee
feat(web): user default container list on deployment screen (#211)
6fba038
fix: container config path must be string instead of path (#214)
347ec94
@balanceee @peterambrus3
feat(web): add new config page
688aea8 
feat(crux-ui): fix build errors

Co-Authored-By: Szabolcs Szigeti <48388277+balanceee@users.noreply.github.com>
@balanceee
fix agent grpc mapper
b27660e
@m8vago
Merge branch 'develop' into feat/image-config-page
fcbf28a
@balanceee
rework agent unique key lists
15445c7
@balanceee
fix complex value changed handler
2413cad
@m8vago
Merge branch 'feat/image-config-page' of github.com:dyrector-io/dyrec…
debc07a 
…torio into feat/image-config-page
@peterambrus3
config pages grid design
6403241
@polaroi8d polaroi8d added issue:enhancement New feature or request source:web The scope of the issue or pull request is web. pr:feat lang:typescript severity:high labels Oct 24, 2022
@balanceee balanceee force-pushed the feat/image-config-page branch 3 times, most recently from e9971e1 to 86e6069 Compare October 25, 2022 08:36
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2022 •
edited
Loading

Codecov Report

Base: 13.64% // Head: 13.63% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (769e620) compared to base (4c03c3e).
Patch coverage: 2.70% of modified lines in pull request are covered.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #297      +/-   ##
===========================================
- Coverage    13.64%   13.63%   -0.01%     
===========================================
  Files           51       51              
  Lines         4874     4876       +2     
===========================================
  Hits           665      665              
- Misses        4187     4189       +2     
  Partials        22       22
Impacted Files Coverage Δ
golang/api/v1/deploy.go 80.61% <ø> (ø)
golang/internal/grpc/grpc.go 0.00% <0.00%> (ø)
golang/internal/mapper/grpc.go 0.00% <0.00%> (ø)
golang/pkg/crane/crux/deploy.go 0.00% <ø> (ø)
golang/internal/util/image.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@balanceee balanceee marked this pull request as ready for review October 25, 2022 09:59
@balanceee balanceee requested a review from a team as a code owner October 25, 2022 09:59
@balanceee balanceee force-pushed the feat/image-config-page branch 2 times, most recently from b1df167 to 5dff799 Compare October 25, 2022 10:33
polaroi8d
polaroi8d reviewed Oct 25, 2022
View reviewed changes
golang/internal/grpc/grpc.go Outdated Show resolved Hide resolved
protobuf/proto/agent.proto Outdated Show resolved Hide resolved
protobuf/proto/agent.proto Show resolved Hide resolved
web/crux/proto/crux.proto Outdated Show resolved Hide resolved
nandor-magyar
nandor-magyar requested changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@nandor-magyar nandor-magyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked go part thoroughly and skimmed the others. See my comments. The more the change, the more respect it is. 🔫

golang/api/v1/deploy.go Show resolved Hide resolved
golang/internal/grpc/grpc.go Outdated Show resolved Hide resolved
protobuf/proto/agent.proto Outdated Show resolved Hide resolved
m8vago
m8vago requested changes Oct 25, 2022
View reviewed changes
golang/internal/dogger/dogger_test.go Show resolved Hide resolved
golang/internal/dogger/dogger_test.go Show resolved Hide resolved
web/crux-ui/locales/en/container.json Outdated Show resolved Hide resolved
web/crux-ui/src/components/products/versions/images/edit-image-json.tsx Outdated Show resolved Hide resolved
web/crux-ui/src/components/products/versions/images/image-config-filters.tsx Outdated Show resolved Hide resolved
web/crux-ui/src/elements/dyo-message.tsx Outdated Show resolved Hide resolved
web/crux-ui/src/server/crux/mappers/image-mappers.ts Outdated Show resolved Hide resolved
web/crux/prisma/schema.prisma Outdated Show resolved Hide resolved
web/crux/src/app/agent/agent.service.ts Outdated Show resolved Hide resolved
web/crux/src/app/deploy/deploy.mapper.ts Outdated Show resolved Hide resolved
@balanceee balanceee force-pushed the feat/image-config-page branch 3 times, most recently from 4c48f6f to 795a642 Compare October 26, 2022 12:27
@balanceee balanceee force-pushed the feat/image-config-page branch 3 times, most recently from 1bc2c94 to c51f975 Compare October 26, 2022 13:47
@polaroi8d
Copy link
Collaborator

Missing E2E tests 🤡

polaroi8d
polaroi8d approved these changes Oct 26, 2022
View reviewed changes
Copy link
Collaborator

@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job @balanceee and @peterambrus3 🔥

m8vago
m8vago reviewed Oct 26, 2022
View reviewed changes
web/crux-ui/src/utils.ts Outdated Show resolved Hide resolved
@balanceee balanceee merged commit c2d282b into develop Oct 27, 2022
@balanceee balanceee deleted the feat/image-config-page branch October 27, 2022 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterambrus3 peterambrus3 peterambrus3 left review comments

@m8vago m8vago m8vago approved these changes

@polaroi8d polaroi8d polaroi8d approved these changes

@nandor-magyar nandor-magyar Awaiting requested review from nandor-magyar

@robot9706 robot9706 Awaiting requested review from robot9706

Assignees

@peterambrus3 peterambrus3

@balanceee balanceee

Labels
issue:enhancement New feature or request lang:typescript pr:feat severity:high source:web The scope of the issue or pull request is web.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@balanceee @codecov-commenter @polaroi8d @m8vago @robot9706 @peterambrus3 @nandor-magyar