Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): use default container list on deployment screen #211

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

balanceee
Copy link
Contributor

@balanceee balanceee commented Sep 28, 2022

From now, on the deployment's log screen you can always see your containers (even if they are deleted). Previously when you started a deplyoment the container's list were uploaded continuously. Now only their status are updated. Also the prefix has been removed from the container's name in case of docker.

@balanceee balanceee marked this pull request as ready for review September 28, 2022 10:44
@balanceee balanceee force-pushed the feat/default-container-list branch 2 times, most recently from 9f49ee6 to a854ee4 Compare September 28, 2022 13:40
@balanceee balanceee changed the title feat(web): user default container list on deployment screen feat(web): use default container list on deployment screen Sep 28, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 7.66% // Head: 7.64% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (25e5032) compared to base (06652cb).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #211      +/-   ##
==========================================
- Coverage     7.66%   7.64%   -0.03%     
==========================================
  Files           44      44              
  Lines         3664    3675      +11     
==========================================
  Hits           281     281              
- Misses        3379    3390      +11     
  Partials         4       4              
Impacted Files Coverage Δ
agent/internal/config/secret.go 0.00% <0.00%> (ø)
agent/internal/mapper/grpc.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@balanceee balanceee force-pushed the feat/default-container-list branch 7 times, most recently from 239b5fa to 7f86007 Compare September 29, 2022 11:14
Copy link
Contributor

@peterambrus3 peterambrus3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤠

@balanceee balanceee merged commit 6fba038 into develop Sep 29, 2022
@balanceee balanceee deleted the feat/default-container-list branch September 29, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants