Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#781 add acemulation_tFilter from dyn db #786

Merged
merged 2 commits into from
Sep 10, 2024
Merged

#781 add acemulation_tFilter from dyn db #786

merged 2 commits into from
Sep 10, 2024

Conversation

gaouizer
Copy link
Contributor

@gaouizer gaouizer commented Sep 9, 2024

Checklist before requesting a review

use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes

  • unit tests and non regression tests were added (update of inputs, outputs, SA, algos)
  • main documentation was updated (update of input/output file)
  • the corresponding milestone was added in the ticket and in this PR

@gaouizer
#781 add acemulation_tFilter from dyn db
381152e 
Signed-off-by: gaouizer <gilles.aouizerate@rte-france.com>
@gaouizer gaouizer added enhancement New feature or request Outputs labels Sep 9, 2024
@gaouizer gaouizer added this to the v1.7.0 milestone Sep 9, 2024
@gaouizer gaouizer self-assigned this Sep 9, 2024
rosiereflo
rosiereflo requested changes Sep 9, 2024
View reviewed changes
sources/Outputs/src/ParHvdc.cpp Outdated Show resolved Hide resolved
sources/Outputs/src/ParHvdc.cpp Outdated Show resolved Hide resolved
@rosiereflo rosiereflo linked an issue Sep 9, 2024 that may be closed by this pull request
[HVDC] add the possibility to override "acemulation_tFilter" parameter with the dynamic database #781
Closed
@gaouizer
#781 add default tFilter value in the outputs constants
021f20d 
Signed-off-by: gaouizer <gilles.aouizerate@rte-france.com>
@rosiereflo rosiereflo merged commit 939b11b into master Sep 10, 2024
5 checks passed
@rosiereflo rosiereflo deleted the 781_acemulation_tFilter_from_ddb branch September 10, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosiereflo rosiereflo rosiereflo approved these changes

@marcochiaramello marcochiaramello Awaiting requested review from marcochiaramello

Assignees

@gaouizer gaouizer

Labels
enhancement New feature or request Outputs
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

[HVDC] add the possibility to override "acemulation_tFilter" parameter with the dynamic database
2 participants
@gaouizer @rosiereflo