#783 properly exit all processes when N simulation fails in NSA #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #783 Signed-off-by: Florentine Rosiere <florentine.rosiere@rte-france.com>
rosiereflo
force-pushed
the
783_nsa_n_fail
branch
from
2772940
to
e0ced48
Compare
gaouizer
approved these changes
Sep 9, 2024
| ] | ||
| }, | ||
| { | ||
| "id": "load_contingency_bad_id", |
There was a problem hiding this comment.
So this will make the N simulation fail (gracefully thanks to your dev) or the SA's?
There was a problem hiding this comment.
in NSA mode + multi-process, only the root process runs the N simulation, and the others processes wait (before starting the scenarios in a second time when the N results are avaialble).
This issue fixes the behavior when the N simulation fails for some reason: in this case, initially the root process was launching an exception and exited peacefully...while the others processes were waiting indefinitely as the sync method was never executed by the root process.
There was a problem hiding this comment.
thus the nrt added is a testcase for which the N fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #783
Checklist before requesting a review
use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes