Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursor doesn't always go down #5

Open
rstacruz opened this issue Oct 15, 2015 · 7 comments
Open

Cursor doesn't always go down #5

rstacruz opened this issue Oct 15, 2015 · 7 comments

Comments

@rstacruz
Copy link
Contributor

First of all, great package! Finally found a project I can use it in.

One problem I often run into is that the cursor doesn't always go down to the last line properly. This can lead to overwriting some wrong lines.

pasted_image_10_15_15__5_01_pm

I'm assuming this is a problem with this line:

out.write(cliColor.down(change - (out.height(output) - 1)));

I think it out.height() needs to strip off ANSI codes before determining the line length.

@rstacruz
Copy link
Contributor Author

Also, offering help to maintain this — cli-color probably needs to be upgraded while we're at it.

@dylang
Copy link
Owner

dylang commented Oct 15, 2015

Pushed a major update with updates or alternatives to all of the dependencies. First time I've touched this module in two years, almost to the day. I'm not using this module for any projects anymore, so thanks for the inspiration to update it.

Let me know if the updates fixed the problem you were having.

@rstacruz
Copy link
Contributor Author

Sure, can you git tag and npm release v1.0.0? :)

edit: it's on npm now, would be cool if you can tag this release and the other too so we can compare using v0.1.1...v1.0.0 :)

@rstacruz
Copy link
Contributor Author

btw, i'm using this today on this package: https://www.npmjs.com/package/metalsmith-start

@dylang
Copy link
Owner

dylang commented Oct 15, 2015

I released it a few hours ago as 1.0.0 but I forgot to tag it.

@dylang
Copy link
Owner

dylang commented Oct 15, 2015

Tagged! Nice project, I'll need to check it out.

@joshgoebel
Copy link

@rstacruz Did this update solve your original issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants