Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest packages; added basic yarn support; added rc file depcheck api support #397

Merged
merged 6 commits into from
Jul 16, 2022
Merged

Latest packages; added basic yarn support; added rc file depcheck api support #397

merged 6 commits into from
Jul 16, 2022

Conversation

dkhunt27
Copy link
Contributor

@dkhunt27 dkhunt27 commented Feb 12, 2021 •
edited
Loading

FYI: I published this PR to npm as npm-check-pr397... temp workaround for now

Updated packages to latest versions:

  • had to update meow to newer config
  • had to switch to stripAnsi
  • lint fixes

Added basic support for yarn (add instead of install; remove --save)
Added support for rcfile and passing options to depcheck

closes

FYI: there is no test coverage; validated several cli paths, but not all with new updates.

dependencies
callsite-record v3 -> v4; didn't see any breaking changes identified in doc
chalk v1 -> v4; fixed stripColor; node >= 10; other breaking changes didn't seem to apply
depcheck v0 -> v1; didn't see any breaking changes identified in doc
execa v0 -> v5; node >= 10; other breaking changes didn't seem to apply
global-modules v1 -> v2; didn't see any breaking changes identified in doc
globby v4 -> v11; node >= 10; other breaking changes didn't seem to apply
inquirer v0 - v7; fixed inquirer.prompt call
is-ci v1 -> v2; didn't see any breaking changes identified in doc
lodash v4 -> v4
meow v3 -> v9; fixed options; node >= 10; other breaking changes didn't seem to apply
node-emoji v1 -> v1
ora v0 -> v5; node >= 10; other breaking changes didn't seem to apply
package-json v4 -> v6; node >= 8; other breaking changes didn't seem to apply
path-exists v2 -> v4; node >= 8; other breaking changes didn't seem to apply
pkg-dir v1 -> v5; node >= 10; other breaking changes didn't seem to apply
preferred-pm v1 -> v3; no release/tags found
rc-config-loader new
semver v5 -> v7; didn't see any breaking changes identified in doc
semver-diff v2 -> v3; node >= 8; other breaking changes didn't seem to apply
strip-ansi new
throat v2 -> v6; node > 10; other breaking changes didn't seem to apply
update-notifier v2 -> v5; node > 10; other breaking changes didn't seem to apply
xtend v4 -> v4

devDependencies
babel-cli v6 -> v6
babel-plugin-transform-object-rest-spread new
babel-plugin-transform-runtime v6 -> v6
babel-preset-es2015 v6 -> v6
xo v0 -> v0

This was referenced Feb 12, 2021
Open
Open
@dkhunt27
updated to latest package versions (node 10+);
fe9e89c 
added support for rcfile;
added babel support for spread operator;
added yarn support;
LinusU
LinusU reviewed Feb 15, 2021
View reviewed changes
lib/cli.js Outdated Show resolved Hide resolved
LinusU
LinusU reviewed Feb 15, 2021
View reviewed changes
lib/index.js Outdated Show resolved Hide resolved
LinusU
LinusU reviewed Feb 15, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
LinusU
LinusU approved these changes Feb 15, 2021
View reviewed changes
Copy link
Collaborator

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, but looks great overall! 🌟 🌟 🌟

LinusU
LinusU reviewed Feb 15, 2021
View reviewed changes
latest.txt Outdated
Comment on lines 1 to 31
dependencies
callsite-record v3 -> v4; didn't see any breaking changes identified in doc
chalk v1 -> v4; fixed stripColor; node >= 10; other breaking changes didn't seem to apply
depcheck v0 -> v1; didn't see any breaking changes identified in doc
execa v0 -> v5; node >= 10; other breaking changes didn't seem to apply
global-modules v1 -> v2; didn't see any breaking changes identified in doc
globby v4 -> v11; node >= 10; other breaking changes didn't seem to apply
inquirer v0 - v7; fixed inquirer.prompt call
is-ci v1 -> v2; didn't see any breaking changes identified in doc
lodash v4 -> v4
meow v3 -> v9; fixed options; node >= 10; other breaking changes didn't seem to apply
node-emoji v1 -> v1
ora v0 -> v5; node >= 10; other breaking changes didn't seem to apply
package-json v4 -> v6; node >= 8; other breaking changes didn't seem to apply
path-exists v2 -> v4; node >= 8; other breaking changes didn't seem to apply
pkg-dir v1 -> v5; node >= 10; other breaking changes didn't seem to apply
preferred-pm v1 -> v3; no release/tags found
rc-config-loader *new*
semver v5 -> v7; didn't see any breaking changes identified in doc
semver-diff v2 -> v3; node >= 8; other breaking changes didn't seem to apply
strip-ansi *new*
throat v2 -> v6; node > 10; other breaking changes didn't seem to apply
update-notifier v2 -> v5; node > 10; other breaking changes didn't seem to apply
xtend v4 -> v4

devDependencies
babel-cli v6 -> v6
babel-plugin-transform-object-rest-spread *new*
babel-plugin-transform-runtime v6 -> v6
babel-preset-es2015 v6 -> v6
xo v0 -> v0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this file be committed? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope... removing

dkhunt27 and others added 5 commits February 15, 2021 11:50
@dkhunt27 @LinusU
Update lib/in/get-unused-packages.js
f1f38df 
switch to const

Co-authored-by: Linus Unnebäck <linus@folkdatorn.se>
@dkhunt27 @LinusU
Update lib/cli.js
59a49af 
switched to set

Co-authored-by: Linus Unnebäck <linus@folkdatorn.se>
@dkhunt27 @LinusU
Update lib/index.js
a9ec38b 
streamline

Co-authored-by: Linus Unnebäck <linus@folkdatorn.se>
@dkhunt27 @LinusU
Update package.json
2d80af4 
updated node version

Co-authored-by: Linus Unnebäck <linus@folkdatorn.se>
@dkhunt27
PR feedback - clean up
0876c0e
@dkhunt27
Copy link
Contributor Author

Updated with PR feedback

@metasean metasean mentioned this pull request Mar 29, 2021
Open
@dkhunt27
Copy link
Contributor Author

any chance of getting this merged?

@dkhunt27
Copy link
Contributor Author

still looking to get this merged... anything else needed?

@JoernBerkefeld
Copy link

@LinusU ??? wanna merge & publish this or hand over the torch? would be great to get this security fix up and running

@dkhunt27
Copy link
Contributor Author

still looking to get this merged

@KlausEverWalkingDev KlausEverWalkingDev mentioned this pull request Mar 13, 2022
Closed
@KlausEverWalkingDev
Copy link

I made a comment about this PR in an issue of another repo where I saw GitHub's @dylang latest activity. I hope it gets noticed. :)

@cmawhorter
Copy link

@dkhunt27 maybe consider formalizing your fork and publishing a github package? i'd be fine with doing npm i @dkhunt27/npm-check or anything else to make all the dependabot noise this package has been causing go away 😢

@sebastiancarlos
Copy link

@dkhunt27 @dylang here's a song I wrote, hoping for the return of npm-check to its former glory.

https://soundcloud.com/sebastian-carlos-396624237/to-the-maintainer-of-npm-check

@dylang
Copy link
Owner

dylang commented Jul 13, 2022

@dkhunt27 @sebastiancarlos and friends, I'm so sorry I haven't been paying attention to this project! I was getting so many github emails I just turned them all off years ago, and I stopped using this when I discovered https://renovatebot.com/.

@sebastiancarlos Your song has brought 😂 to me, my wife, and co-workers.

I'm typing this at a cafe without much power remaining, I'll try to get to this and other important PRs soon.

Thank you for your support and patience, and I'm sorry for the long wait and zero communication.

@dylang dylang merged commit 3c8798d into dylang:master Jul 16, 2022
@snyk-io snyk-io bot mentioned this pull request Jul 26, 2024
Open
@benmccann benmccann mentioned this pull request Aug 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinusU LinusU LinusU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dkhunt27 @JoernBerkefeld @KlausEverWalkingDev @cmawhorter @sebastiancarlos @dylang @LinusU