-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest packages; added basic yarn support; added rc file depcheck api support #397
Conversation
added support for rcfile; added babel support for spread operator; added yarn support;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments, but looks great overall! 🌟 🌟 🌟
latest.txt
Outdated
dependencies | ||
callsite-record v3 -> v4; didn't see any breaking changes identified in doc | ||
chalk v1 -> v4; fixed stripColor; node >= 10; other breaking changes didn't seem to apply | ||
depcheck v0 -> v1; didn't see any breaking changes identified in doc | ||
execa v0 -> v5; node >= 10; other breaking changes didn't seem to apply | ||
global-modules v1 -> v2; didn't see any breaking changes identified in doc | ||
globby v4 -> v11; node >= 10; other breaking changes didn't seem to apply | ||
inquirer v0 - v7; fixed inquirer.prompt call | ||
is-ci v1 -> v2; didn't see any breaking changes identified in doc | ||
lodash v4 -> v4 | ||
meow v3 -> v9; fixed options; node >= 10; other breaking changes didn't seem to apply | ||
node-emoji v1 -> v1 | ||
ora v0 -> v5; node >= 10; other breaking changes didn't seem to apply | ||
package-json v4 -> v6; node >= 8; other breaking changes didn't seem to apply | ||
path-exists v2 -> v4; node >= 8; other breaking changes didn't seem to apply | ||
pkg-dir v1 -> v5; node >= 10; other breaking changes didn't seem to apply | ||
preferred-pm v1 -> v3; no release/tags found | ||
rc-config-loader *new* | ||
semver v5 -> v7; didn't see any breaking changes identified in doc | ||
semver-diff v2 -> v3; node >= 8; other breaking changes didn't seem to apply | ||
strip-ansi *new* | ||
throat v2 -> v6; node > 10; other breaking changes didn't seem to apply | ||
update-notifier v2 -> v5; node > 10; other breaking changes didn't seem to apply | ||
xtend v4 -> v4 | ||
|
||
devDependencies | ||
babel-cli v6 -> v6 | ||
babel-plugin-transform-object-rest-spread *new* | ||
babel-plugin-transform-runtime v6 -> v6 | ||
babel-preset-es2015 v6 -> v6 | ||
xo v0 -> v0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this file be committed? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope... removing
switch to const Co-authored-by: Linus Unnebäck <linus@folkdatorn.se>
switched to set Co-authored-by: Linus Unnebäck <linus@folkdatorn.se>
streamline Co-authored-by: Linus Unnebäck <linus@folkdatorn.se>
updated node version Co-authored-by: Linus Unnebäck <linus@folkdatorn.se>
Updated with PR feedback |
any chance of getting this merged? |
still looking to get this merged... anything else needed? |
@LinusU ??? wanna merge & publish this or hand over the torch? would be great to get this security fix up and running |
still looking to get this merged |
I made a comment about this PR in an issue of another repo where I saw GitHub's @dylang latest activity. I hope it gets noticed. :) |
@dkhunt27 maybe consider formalizing your fork and publishing a github package? i'd be fine with doing |
@dkhunt27 @dylang here's a song I wrote, hoping for the return of https://soundcloud.com/sebastian-carlos-396624237/to-the-maintainer-of-npm-check |
@dkhunt27 @sebastiancarlos and friends, I'm so sorry I haven't been paying attention to this project! I was getting so many github emails I just turned them all off years ago, and I stopped using this when I discovered https://renovatebot.com/. @sebastiancarlos Your song has brought 😂 to me, my wife, and co-workers. I'm typing this at a cafe without much power remaining, I'll try to get to this and other important PRs soon. Thank you for your support and patience, and I'm sorry for the long wait and zero communication. |
FYI: I published this PR to npm as npm-check-pr397... temp workaround for now
Updated packages to latest versions:
Added basic support for yarn (add instead of install; remove --save)
Added support for rcfile and passing options to depcheck
closes
FYI: there is no test coverage; validated several cli paths, but not all with new updates.
dependencies
callsite-record v3 -> v4; didn't see any breaking changes identified in doc
chalk v1 -> v4; fixed stripColor; node >= 10; other breaking changes didn't seem to apply
depcheck v0 -> v1; didn't see any breaking changes identified in doc
execa v0 -> v5; node >= 10; other breaking changes didn't seem to apply
global-modules v1 -> v2; didn't see any breaking changes identified in doc
globby v4 -> v11; node >= 10; other breaking changes didn't seem to apply
inquirer v0 - v7; fixed inquirer.prompt call
is-ci v1 -> v2; didn't see any breaking changes identified in doc
lodash v4 -> v4
meow v3 -> v9; fixed options; node >= 10; other breaking changes didn't seem to apply
node-emoji v1 -> v1
ora v0 -> v5; node >= 10; other breaking changes didn't seem to apply
package-json v4 -> v6; node >= 8; other breaking changes didn't seem to apply
path-exists v2 -> v4; node >= 8; other breaking changes didn't seem to apply
pkg-dir v1 -> v5; node >= 10; other breaking changes didn't seem to apply
preferred-pm v1 -> v3; no release/tags found
rc-config-loader new
semver v5 -> v7; didn't see any breaking changes identified in doc
semver-diff v2 -> v3; node >= 8; other breaking changes didn't seem to apply
strip-ansi new
throat v2 -> v6; node > 10; other breaking changes didn't seem to apply
update-notifier v2 -> v5; node > 10; other breaking changes didn't seem to apply
xtend v4 -> v4
devDependencies
babel-cli v6 -> v6
babel-plugin-transform-object-rest-spread new
babel-plugin-transform-runtime v6 -> v6
babel-preset-es2015 v6 -> v6
xo v0 -> v0