[OTE-538] feat(OE): Abort OE in PrepareProposal #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@teddyding your pull request is missing a changelog! |
teddyding
force-pushed
the
td/abort-oe-prepare
branch
from
420dbdc
to
e374cd4
Compare
![github-actions[bot]](https://github.com/avatars/in/15368?s=60&v=4){kind=small}
|
Hi! This seems to be a great addition to the base SDK. Are you willing to submit a PR that targets the main branch of the SDK? |
teddyding
force-pushed
the
td/abort-oe-prepare
branch
from
e374cd4
to
e5c3ffd
Compare
teddyding
commented
Jul 18, 2024
baseapp/abci.go
Outdated
| // Overlap is undesirable, since internalFinalizeBlock` and `PrepareProoposal` could share access to | ||
| // in-memory structs. | ||
| // No-op if OE is not enabled. | ||
| // Similar call to Abort() is done in `ProcessProposal` |
There was a problem hiding this comment.
See
Line 512 in 649319c
teddyding
force-pushed
the
td/abort-oe-prepare
branch
from
e5c3ffd
to
bbebe9a
Compare
teddyding
force-pushed
the
td/abort-oe-prepare
branch
2 times, most recently
from
543d2c9
to
db7aa44
Compare
teddyding
force-pushed
the
td/abort-oe-prepare
branch
from
db7aa44
to
9b603a3
Compare
vincentwschau
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See inline comment for reasoning.
More Context