go-fuzz-build: respect GO111MODULE if set #272
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an alternative to dvyukov#271. Updates dvyukov#195
|
@josharian looks like it fails the CI. |
|
Ah, the CI failed because there's a CI configuration that explicitly sets GO111MODULE=on. Which doesn't work for our tests. @thepudds what do you think the right thing to do here is? |
|
I'm in favour of merging #271 asap as it doesn't affect the current users and tests at all and it remove the block for a lot of users that are waiting for long time for this one: https://twitter.com/fuzzitdev/status/1169137825142452225 |
|
I’m closing this in favor of #274, which I will review ASAP, probably within the next few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #271.
Updates #195
cc @mvdan @yevgenypats @dvyukov