-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
playground: image & cache #86
base: master
Are you sure you want to change the base?
Conversation
@@ -259,7 +258,7 @@ | |||
color: #428bca; | |||
background-color: #fff; | |||
} | |||
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you using an EditorConfig plugin in your IDE?
@@ -3,7 +3,6 @@ | |||
$url = @$_POST['url'] ?: @$_GET['url']; | |||
$sel = @$_POST['sel'] ?: @$_GET['sel']; | |||
$go = @$_POST['go'] ?: @$_GET['go']; | |||
$ch = @$_POST['ch'] ?: @$_GET['ch']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$_GET['ch']
allow to save the state in the URL and preserve it during refreshes. Maybe not a big deal for the cache expires, but I'd prefer to have consistency over all variables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eg. http://localhost:8074/playground.php?url=http://duzun.me&sel=a%20img:parent&ch=10
.
@@ -281,7 +281,7 @@ | |||
<form name="hquery" action="" method="post"> | |||
<p><label>URL: <input type="url" name="url" value="<?=htmlspecialchars(@$url??'', ENT_QUOTES);?>" placeholder="e.g. https://mariauzun.com/portfolio" autofocus class="form-control" required /></label></p> | |||
<p><label>Selector: <input type="text" name="sel" value="<?=htmlspecialchars(@$sel??'', ENT_QUOTES);?>" placeholder="e.g. 'a[href] > img[src]:parent'" class="form-control" required /></label></p> | |||
<p><label>Cache: <input type="number" name="ch" value="<?=$_POST['ch']>=0?@$_POST['ch']:1800;?>" min="0" max="3600" placeholder="e.g. 1800" class="form-control" /> (seconds)</label></p> | |||
<p><label>Cache: <input type="number" name="ch" value="<?=$_POST['ch']==='0'||(int)$_POST['ch']>0?@$_POST['ch']:'';?>" min="0" max="3600" placeholder="e.g. 600" class="form-control" /> (seconds) <code>default: 3600</code></label></p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line repeats the logic for ch
.
max-width:300px;
0