Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Groups UI] - Breadcrumbs #6674

Closed
JulesBelveze opened this issue Aug 6, 2024 · 1 comment · Fixed by #6889
Closed

[Groups UI] - Breadcrumbs #6674

JulesBelveze opened this issue Aug 6, 2024 · 1 comment · Fixed by #6889
Assignees
@philipperolet

Comments

@JulesBelveze
Copy link
Contributor

No description provided.

@tdraier tdraier mentioned this issue Aug 20, 2024
Closed
@philipperolet
Copy link
Contributor

As discussed IRL with @flvndvd this task updates existing breadcrumbs to make them work well:

  • they should be part of the vault layout (vs repeated on every page
  • they should be inferred from URL
  • the ellipsis should be handled properly (should be between first and last element, not at the end)

@philipperolet philipperolet self-assigned this Aug 22, 2024
philipperolet added a commit that referenced this issue Aug 23, 2024
@philipperolet
[Vaults] Breadcrumbs
5834677 
Description
---
Fixes #6674

- Refactor breadcrumbs & move them in a single place (VaultLayout)
- Fix them:
  - last item of breadcrumbs always visible
  - ellipsis appears in middle instead of end
  - clic on ellipsis goes up in the hierarchy
  - fixes mixed up category names

Risk
---
- call to useSWR in VaultLayout, likely harmless (null call when not
in hierarchy, otherwise small call) => @Reviewer do you agree?

Deploy
---
front
@philipperolet philipperolet mentioned this issue Aug 23, 2024
Merged
philipperolet added a commit that referenced this issue Aug 26, 2024
@philipperolet
[Vaults] Breadcrumbs
77f67a7 
Description
---
Fixes #6674

- Refactor breadcrumbs & move them in a single place (VaultLayout)
- Fix them:
  - last item of breadcrumbs always visible
  - ellipsis appears in middle instead of end
  - clic on ellipsis goes up in the hierarchy
  - fixes mixed up category names

Risk
---
- call to useSWR in VaultLayout, likely harmless (null call when not
in hierarchy, otherwise small call) => @Reviewer do you agree?

Deploy
---
front
philipperolet added a commit that referenced this issue Aug 26, 2024
@philipperolet
[Vaults] Breadcrumbs
0206696 
Description
---
Fixes #6674

- Refactor breadcrumbs & move them in a single place (VaultLayout)
- Fix them:
  - last item of breadcrumbs always visible
  - ellipsis appears in middle instead of end
  - clic on ellipsis goes up in the hierarchy
  - fixes mixed up category names

Risk
---
- call to useSWR in VaultLayout, likely harmless (null call when not
in hierarchy, otherwise small call) => @Reviewer do you agree?

Deploy
---
front
philipperolet added a commit that referenced this issue Aug 26, 2024
@philipperolet
[Vaults] Breadcrumbs
b71b03c 
Description
---
Fixes #6674

- Refactor breadcrumbs & move them in a single place (VaultLayout)
- Fix them:
  - last item of breadcrumbs always visible
  - ellipsis appears in middle instead of end
  - clic on ellipsis goes up in the hierarchy
  - fixes mixed up category names

Risk
---
- call to useSWR in VaultLayout, likely harmless (null call when not
in hierarchy, otherwise small call) => @Reviewer do you agree?

Deploy
---
front
philipperolet added a commit that referenced this issue Aug 27, 2024
@philipperolet
[Vaults] Breadcrumbs (#6889)
8c3a637 
* [Vaults] Breadcrumbs

Description
---
Fixes #6674

- Refactor breadcrumbs & move them in a single place (VaultLayout)
- Fix them:
  - last item of breadcrumbs always visible
  - ellipsis appears in middle instead of end
  - clic on ellipsis goes up in the hierarchy
  - fixes mixed up category names

Risk
---
- call to useSWR in VaultLayout, likely harmless (null call when not
in hierarchy, otherwise small call) => @Reviewer do you agree?

Deploy
---
front

* review

* review 2

* lean

* clean

* review n

* clean
albandum pushed a commit that referenced this issue Aug 28, 2024
@philipperolet @albandum
[Vaults] Breadcrumbs (#6889)
f5eca89 
* [Vaults] Breadcrumbs

Description
---
Fixes #6674

- Refactor breadcrumbs & move them in a single place (VaultLayout)
- Fix them:
  - last item of breadcrumbs always visible
  - ellipsis appears in middle instead of end
  - clic on ellipsis goes up in the hierarchy
  - fixes mixed up category names

Risk
---
- call to useSWR in VaultLayout, likely harmless (null call when not
in hierarchy, otherwise small call) => @Reviewer do you agree?

Deploy
---
front

* review

* review 2

* lean

* clean

* review n

* clean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philipperolet philipperolet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Vaults] Breadcrumbs dust-tt/dust
2 participants
@philipperolet @JulesBelveze