Fix Hanging query #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moved buffered_query_result -> stream_query_result initialize buffered count use the buffered query result in the sqllogic tester uncomment Materialize, taken from StreamQueryResult use Initialize and Copy added TODO move the Fetch logic into the BufferedQueryResult, will be the exact same for the batched variant add virtual destructor introduce base class BufferedData, SimpleBufferedData inherits from it preparation for batched variant keep track of how many tuples would be added, to reduce the chance we unblock a sink only for it to block again right away add assertion to make sure doesn't go out into random memory always output chunks of STANDARD_VECTOR_SIZE from Fetch if possible, have to construct this from (potentially) many smaller chunks fix CI move BufferedData out of BufferedQueryResult PoC seems to be working formatting create the QueryResult before the pipeline is complete so we can keep it blocked and unblock it later
|
Done in #90. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #86, duckdb/duckdb#10245 would cause a simple case in duckdb-r to hang. This PR presents a solution that better addresses the infinite loop issue. Apparently Query results can be
blockedorfinishedifallow_streaming_result = true. For arrow, we passtruefor streaming result, so we need to check is the result is blocked or finished instead of just finished. A blocked query just meansfetchneeds to be called.