Add HTTP POST support to the HTTP client #151
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful to know what's going on without having to dig deep. For instance, the retro-go HTTP API will return 404 to: http://192.168.4.1/%2fsd%2fcrash.log but not to: http://192.168.4.1/sd%2fcrash.log But without seeing the status code, it's kind of guess work as to why exactly rg_network_http_open() failed. Or it will not provide a Content-Length field for download file requests, but it *will* assume that other HTTP servers do provide it, such as in updater.c's download_file() to show the total bytes to download. An informational "content length: 0" would have helped to understand this.
Using the unused rg_http_cfg_t for this, assuming that's what it is for. If rg_http_cfg_t->post_data is provided, the http client will do a POST request with that data.
tomvanbraeckel
changed the title
|
It's a good idea to add POST support and your adhoc/p2p networking plans sound ambitious and pretty fun! |
ducalex
force-pushed
the
dev
branch
12 times, most recently
from
8874d4b
to
3d3cbb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using this for of my (experimental, but working!) "find games" functionality, where one retro-go device connects to another's wifi hotspot and recursively "finds" (and downloads) ROMs that it doesn't have yet.
The idea is that kids can easily share games with each other this way, especially self-made GameBoy Color games as it looks like there will be a GBStudio workshop at Fri3d camp!
I'm thinking of giving the users a high-level choice of which ROM folders to check (/sd/roms/ or /sd/roms/gbc/ or /sd/roms/nes or /sd/roms/gb or /sd/roms/doom etc) to make it faster and more selective, in case there are many games.
Even better would be to to create a nice new "remote file browser" tab that properly allows you to browse another retro-go's (or in general. any webserver's) files. This could use the default http://192.168.4.1/ (assuming you're connected to another retro-go's wifi hotspot) but it would be nice to have some way of configuring this URL. So a method of entering an IP address or generic text on the retro-go would be cool... dream, dream, dream!