Prevent directory traversal in server-supplied filenames #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blyxxyz
force-pushed
the
re-fix-download-path-escape
branch
from
eb25c52
to
841f9c2
Compare
ducaale
changed the base branch from
master
to
hotfix/v0.22.0-re-fix-download-path-escape
ducaale
approved these changes
Jul 8, 2024
ducaale
merged commit c2591d5
into
ducaale:hotfix/v0.22.0-re-fix-download-path-escape
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
Content-Dispositionheader includes directory separators (e.g./) then we now only take the base filename. Including the directories is a vulnerability.Originally fixed in 028cbb0 but then broken again in 330d3f2. This time I added a regression test.
Fixes #378.
(Commit based on v0.22.0, we could do a bugfix release instead of a feature release.)