-
-
Notifications
You must be signed in to change notification settings - Fork 151
more string quoting #398
base: master
Are you sure you want to change the base?
more string quoting #398
Conversation
|| lower_scalar == "null" | ||
|| lower_scalar == "nil" | ||
|| lower_scalar == "~" | ||
|| lower_scalar == "nan" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great if this would also cover the float
or string
issue: https://hitchdev.com/strictyaml/why/implicit-typing-removed/#string-or-float
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fzgregor tests added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
"NULL", | ||
"nil", | ||
"Nil", | ||
"NIL", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A test string for float
or string
would be 2E234567
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fzgregor i added this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
@thedavidmeister what's your thinking about this PR? Is it ready to be merged? |
fixes #397 #319