Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]-corrected the #275 pull request #277

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

shyamcody
Copy link

Made the following changes:
(1) type_ changed to output.
(2) changed the documentation for return.
(3) added test function to check the shape as well as valueError.

@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #277 into master will decrease coverage by 0.15%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
- Coverage   95.21%   95.06%   -0.16%     
==========================================
  Files          22       22              
  Lines        3178     3202      +24     
==========================================
+ Hits         3026     3044      +18     
- Misses        152      158       +6     
Impacted Files Coverage Δ
pygam/distributions.py 88.40% <ø> (ø)
pygam/tests/test_GAM_methods.py 98.97% <88.88%> (-1.03%) ⬇️
pygam/pygam.py 94.83% <91.66%> (+0.03%) ⬆️
pygam/tests/test_utils.py 95.10% <0.00%> (-1.40%) ⬇️
pygam/utils.py 87.42% <0.00%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b57b4cf...e6df9ad. Read the comment docs.

@shyamcody
Copy link
Author

@dswah just check this pull once. All of the tests have passed successfully; so probably good to go.

@shyamcody shyamcody marked this pull request as ready for review July 15, 2020 20:41
@shyamcody
Copy link
Author

shyamcody commented Jul 20, 2020

Changed the gamma parameter from being default in 1.4 to a user side parameter. #76 should be solved with this. Successfully added gamma and test.

@shyamcody shyamcody changed the title corrected the #275 pull request [WIP]-corrected the #275 pull request Jul 20, 2020
@shyamcody shyamcody force-pushed the master branch 4 times, most recently from 68fde43 to f411c35 Compare July 21, 2020 10:17
@shyamcody
Copy link
Author

@dswah can you merge this change for now? I tried my hand with further development; but seems I am not able to do anything for now. So would like to get this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants