Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm creating this request to start a conversation about adding Poetry to the project for dependency management.
Poetry allows for easy dependency management while ensuring there are no clashes. I've added the dependencies mentioned in
requirements/management.txt
as dev dependencies to poetry. Dependencies inrequirements/cli.txt
andrequirements/webapp.txt
have been added as optional extras dependencies. And finally, the dependencies inrequirements/main.txt
have been added as the main dependencies for the project.You can test this locally through the following steps
poetry install --all-extras
from project root to set up a poetry venv and install all dependenciespoetry run
in front of the commandWe can do the following things easily through poetry
poetry run coverage run -m pytest --cov-report xml:cov.xml --cov-report term
poetry build
poetry publish
. This will require configuring poetry with PyPI credentials.In addition to all this, we can also automate testing when a PR is made using
GitHub Actions
. Using this method, we can block PRs from being merged if the unit tests fail. `GitHub Actions will also allow us to automatically build and publish packages when a PR is merged. Doing all this setup requires us to add PyPI credentials to GitHub secrets at minimum, and we might need to change some GitHub settings, too.I wanted to start a conversation using this MR so we can get some opinions from the original maintainers. We will need someone with admin access to the repo to help us add secrets and block PRs from merging when the unit tests fail.
@sgpjesus FYI