Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Any as an alias for object to describe a default typeclass implementation #307

Open
anatoly-scherbakov opened this issue Sep 13, 2021 · 0 comments

Comments

@anatoly-scherbakov
Copy link

Context. In order to define a default implementation (the one used if no other implementation matches), we currently have to write something like this:

from classes import typeclass

@typeclass
def render(data_value) -> str:
    """Render a data value nicely."""

@render.instance(int)
def _render_int(data_value: int) -> str:
    return f'This is an integer: {data_value}'


@render.instance(object)
def _render_int(data_value: object) -> str:
    return f'No idea what this is: {data_value}'


assert render('BADOOM') == 'No idea what this is: BADOOM'

(this script should be runnable as-is.)

Decision. Support Any as a special case to replace object:

@render.instance(Any)
def _render_int(data_value: Any) -> str:    # type: ignore
    return f'No idea what this is: {data_value}'

Consequences.

  • Pro: The code will look a little bit more straightforward;
  • Contra: mypy with common settings might be unhappy about Any being used, but that can be silenced with type: ignore I suppose.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant