[ML] Remove toVersion method from MlConfigVersion

There's no need for a toVersion method in MlConfigVersion.
droberts195 · Sep 25, 2023 · 5cfc4ac · 5cfc4ac
1 parent 6b7c4e2
commit 5cfc4ac
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 18 deletions.
diff --git a/x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/MlConfigVersion.java b/x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/MlConfigVersion.java
@@ -278,13 +278,6 @@ public static MlConfigVersion fromVersion(Version version) {
         return fromId(version.id);
     }
 
-    public static Version toVersion(MlConfigVersion mlConfigVersion) {
-        if (mlConfigVersion.before(FIRST_ML_VERSION) || mlConfigVersion.onOrAfter(V_8_10_0)) {
-            throw new IllegalArgumentException("Cannot convert " + mlConfigVersion + ". Incompatible version");
-        }
-        return Version.fromId(mlConfigVersion.id);
-    }
-
     public static MlConfigVersion getMinMlConfigVersion(DiscoveryNodes nodes) {
         return getMinMaxMlConfigVersion(nodes).v1();
     }

diff --git a/x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/ml/MlConfigVersionTests.java b/x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/ml/MlConfigVersionTests.java
@@ -250,17 +250,6 @@ public void testFromVersion() {
         assertEquals("Cannot convert " + Version.fromId(8_11_00_99) + ". Incompatible version", e.getMessage());
     }
 
-    public void testToVersion() {
-        MlConfigVersion mlConfigVersion_V_7_7_0 = MlConfigVersion.V_7_0_0;
-        Version version_V_7_7_0 = MlConfigVersion.toVersion(mlConfigVersion_V_7_7_0);
-        assertEquals(version_V_7_7_0.id, mlConfigVersion_V_7_7_0.id());
-
-        // There's no mapping between Version and MlConfigVersion values from MlConfigVersion.V_10 onwards.
-        MlConfigVersion mlConfigVersion_V_10 = MlConfigVersion.V_10;
-        Exception e = expectThrows(IllegalArgumentException.class, () -> MlConfigVersion.toVersion(mlConfigVersion_V_10));
-        assertEquals("Cannot convert " + mlConfigVersion_V_10 + ". Incompatible version", e.getMessage());
-    }
-
     public void testVersionConstantPresent() {
         Set<MlConfigVersion> ignore = Set.of(MlConfigVersion.ZERO, MlConfigVersion.CURRENT, MlConfigVersion.FIRST_ML_VERSION);
         assertThat(MlConfigVersion.CURRENT, sameInstance(MlConfigVersion.fromId(MlConfigVersion.CURRENT.id())));