Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #668
General Notes
URLPattern
whereas the Node version (which is what the Bun version uses) uses the old way of handling resource paths. @ebebbington, remember when you added those regex patterns for optional params? Yea... the Bun implementation is using that stuff and it's fast.Headers
URLPattern
src/core
andsrc/node
). This is because Node does not fully support the Web APIs (I could be wrong IDK...)benchmarks
directory. We have Bun, Deno, and Node apps. Node apps come in ESM and CJS versions.RequestHandler
andResourceHandler
classes build their own chains which run inPromise
objects. Also, Drash is mostlyasync
-- we return aPromise
in most cases so as not to block anything. The only places where we reallyawait
are in the services code because those need to be executed in sequential order.Promise.all()
will not work here because if you have 5 services for example, then the 5th service could change the response before the 1st service has a chance to act on it.Node stuff