-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add resource loader service (takes in paths and loads resources from it) #644
Conversation
0be6038
to
92f7834
Compare
aff8820
to
1479fee
Compare
@Guergeiro @ebebbington , not sure what's going on with the windows test with trying to dynamically import
is that a thing on windows? lol. no rush on this. check when you're free. |
@crookse maybe use a combo of, or one of: new URL or import.meta.main? |
continue; | ||
} | ||
|
||
const realPath = await Deno.realPath("./" + entry.path); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the problem Windows paths don't work like that. I would advise using join
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that was annoying 😮💨 : 36ec759
…nstead of forEach; use walkSync instead of walk (leaking async ops)
0ecbcac
to
114406d
Compare
…port fix(services/resource_loader): resource loader dynamic import
Closes #622
TODO
resource
config is optionalSummary
ResourceLoaderService
drash_resource
property toDrash.Resource
to help identify extended resources as aDrash.Resource
resources
service config optional since they can be loaded via theResourceLoaderService
Example Usage
If the folder structure looks like: