fix: hardcoded redirection http status #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers to be specified for .redirect() Trying to make this more like the response class' body methods.
crookse
added
the
Type: Patch
3 tasks
Guergeiro
reviewed
Feb 15, 2022
src/types.ts
Outdated
Comment on lines
27
to
35
| export type HttpStatusRedirection = | ||
| | 300 | ||
| | 301 | ||
| | 302 | ||
| | 303 | ||
| | 304 | ||
| | 305 | ||
| | 307 | ||
| | 308; |
There was a problem hiding this comment.
Question about this. I know that 3xx are the redirect status codes, but do you think we should be so strict about the status codes? Maybe someone wants to mask the url and not give a 3xx status code. I'm not sure...
There was a problem hiding this comment.
i see. yea maybe we shouldn't be strict in this regard. i don't know if a use case outside of 3xx, but maybe there is one
There was a problem hiding this comment.
Yes, my question is exactly that... Don't know if it's a valid thing or not. I'm for the restriction of 3xx, but I'm not sure if there's a use case.
Guergeiro
approved these changes
Feb 15, 2022
ebebbington
approved these changes
Feb 15, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #607
Summary
resource.redirect()methodstatusandheadersto be specified inresource.redirect()(just like the response class' methods)statuscan only be of typeHttpStatusRedirectionwhich ranges from 300 - 308 (excluding 306 since it's not a used status)Other Notes
resource.redirect()method in favor ofresponse.redirect()sinceresponse.redirect()is the native way to do it based on MDN docs. I didn't knowresponse.redirect()existed, so my bad on opting forresource.redirect()