Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use .npmignore - Use "files" in package.json. #29

Merged
merged 3 commits into from
Sep 3, 2020

Conversation

infacto
Copy link
Contributor

@infacto infacto commented Sep 2, 2020

Fixes #27

From (old package content):

seymour
|= .github
|  \= workflows
|     \- ci.yml
|= bin
|  |- seymour
|  \- seymour.cmd
|= src
|  \- seymour.js
|- .editorconfig
|- .eslintrc
|- CHANGELOG.md
|- CODE_OF_CONDUCT.md
|- LICENCE
|- package.json
\- README.md

To (new package content with this commit):

package
|= src
|  \- seymour.js
|= bin
|  |- seymour
|  \- seymour.cmd
|- CHANGELOG.md
|- LICENCE
|- package.json
\- README.md

@dpogue
Copy link
Owner

dpogue commented Sep 2, 2020

This project is pretty much a perfect example of "npmignore is hard to keep up-to-date and you shouldn't use it" 😅
Thanks for the pull request to fix that!

You should (if you want) also add your name to the contributors list in package.json.

@dpogue dpogue merged commit 89ed669 into dpogue:master Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't use .npmignore - Use "files" in package.json.
2 participants