Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: SEY_BUILD_TYPE => SEY_BUILD_MODE #64

Closed
MikeDimmickMnetics opened this issue Nov 30, 2021 · 1 comment · Fixed by #65
Closed

Documentation: SEY_BUILD_TYPE => SEY_BUILD_MODE #64

MikeDimmickMnetics opened this issue Nov 30, 2021 · 1 comment · Fixed by #65

Comments

@MikeDimmickMnetics
Copy link

The SEY_BUILD_TYPE environment variable does not work - no matter how it is set, you get a debug build.

Looking at the code, I can see that a variable SEY_BUILD_MODE will, if set to 'release', produce a release build. Otherwise you get a debug build.

Please update the documentation with the correct variable name.

Tested on v2.1.0, since I'm trying to add Seymour to a Cordova 7.1.0 project, but it looks like this is also the case in v5.0.0.
dpogue added a commit that referenced this issue Dec 1, 2021
@dpogue
Correct SEY_BUILD_MODE docs
019e242 
Closes #64.
@dpogue dpogue mentioned this issue Dec 1, 2021
Merged
@dpogue
Copy link
Owner

dpogue commented Dec 1, 2021

Oops! Thanks for catching this!

I've updated the README to reflect the correct variable name (which is SEY_BUILD_MODE, as you noted)

@dpogue dpogue closed this as completed in #65 Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct SEY_BUILD_MODE docs dpogue/seymour
2 participants
@dpogue @MikeDimmickMnetics