Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated toBeInDOM method #524

Merged
merged 1 commit into from
Jul 21, 2018
Merged

Replace deprecated toBeInDOM method #524

merged 1 commit into from
Jul 21, 2018

Conversation

alexandernanberg
Copy link
Collaborator

What:
Replace deprecated jest-dom method

Why:
toBeInDOM is deprecated
testing-library/jest-dom#34

How:
Replace deprecated toBeInDOM with toBeNull and/or toBeInstanceOf

Checklist:

  • Documentation N/A
  • Tests N/A
  • Ready to be merged
  • Added myself to contributors table N/A

kentcdodds
kentcdodds approved these changes Jul 21, 2018
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super! Thanks!

@kentcdodds kentcdodds merged commit 5a2b0e3 into downshift-js:master Jul 21, 2018
@alexandernanberg alexandernanberg deleted the chore/replace-depricated-jest-dom-fn branch July 22, 2018 07:17
Rendez pushed a commit to Rendez/downshift that referenced this pull request Sep 30, 2018
@alexandernanberg @Rendez
chore(tests): replace deprecated toBeInDOM method (downshift-js#524)
184e096
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandernanberg @kentcdodds