Decreased SolidBrush creation/destruction #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Built cache for SolidBrush creation, saves about 3-4% on render. This will have to be modified for large palettes (start destroying least used brushes), but this should be good for the 95% case.
|
The real win to be had here, I'm sure you've figured out, is the RenderOpen dispose in SetCellCharacter. That was too much surgery for me ;) and I see you're working on it already. |
|
Oh nice! Yeah this is excellent. We probably want some sort of eviction policy/LRU so we don't overdo caching. Spot on with the changes to improve rendering (I'm slowly getting there) but even then caching these will be a big win. The render cost is still way higher than I'd like it to be so even ~5% incremental improvements here are huge. I'm going to try and get my Big Render Change branch into a functional state and then take this PR or a modified varinat. |
|
Going to grab this and then implement the LRU stuff over top quickly. |
|
I’ve already got it. Give me a few minutes :)
From: Chip Locke <notifications@github.com>
Sent: Tuesday, December 4, 2018 3:06 PM
To: doubleyewdee/condo <condo@noreply.github.com>
Cc: Barry Nolte <barry@barrynolte.com>; Author <author@noreply.github.com>
Subject: Re: [doubleyewdee/condo] Decreased SolidBrush creation/destruction (#4)
Going to grab this and then implement the LRU stuff over top quickly.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#4 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AERFPckoePhDXHnxUexLBEztK3nKmYVNks5u1v_PgaJpZM4Y9ghQ> . <https://github.com/notifications/beacon/AERFPYdxF_HKO4WbjBLVZU-hxdBByQISks5u1v_PgaJpZM4Y9ghQ.gif>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built cache for SolidBrush creation, saves about 3-4% on render. This will have to be modified for large palettes (start destroying least used brushes), but this should be good for the 95% case.