Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

将Freesql的dynamicfilterinfo标记为[serialable] #802

Closed
835718973 opened this issue Jun 18, 2021 · 4 comments
Closed

将Freesql的dynamicfilterinfo标记为[serialable] #802

835718973 opened this issue Jun 18, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@835718973
Copy link

835718973 commented Jun 18, 2021 •
edited by luoyunchong

Freesql的DynamicFilterInfo目前未标记未[Serialble]，目前我在远程RPC的工程中需要序列化传递dynamicfilterInfo,是否可以将其标记为可序列化或者有其它原因导致不能这么做？
@luoyunchong
Copy link
Collaborator

luoyunchong commented Jun 18, 2021 •
edited

先用一个类继承这个类，加上[Serializable],看测试可以吗。
如果测试能解决问题。

DynamicFilterInfo类加上[Serializable]，PR is Welcome!

@2881099
Copy link
Collaborator

2881099 commented Jun 18, 2021

传 string 也可以的，DynamicFilterInfo 和 JSON 可以互转

@luoyunchong luoyunchong added the enhancement New feature or request label Jun 18, 2021
@835718973
Copy link
Author

image
请问下拉去源码后编译产生了许多这种错误，但是代码本身并没有提示错误，有什么其它注意事项吗？
因为有许多其它参数需要一起处理，直接序列化会高效与方便许多，所以如果没有不良影响，希望能够添加此特性

1 similar comment
@835718973
Copy link
Author

image
请问下拉去源码后编译产生了许多这种错误，但是代码本身并没有提示错误，有什么其它注意事项吗？
因为有许多其它参数需要一起处理，直接序列化会高效与方便许多，所以如果没有不良影响，希望能够添加此特性

luoyunchong added a commit that referenced this issue Jun 18, 2021
@luoyunchong
#802 Add Serializable
6414234
2881099 added a commit that referenced this issue Aug 31, 2021
@2881099
v2.6.100 #843 #816 #815 #804 #803 #802
e0f9db7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@2881099 @luoyunchong @835718973