Add support for passing a runsettings path to the server #6265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeRobich
reviewed
Aug 31, 2023
Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com>
Cosifne
reviewed
Sep 11, 2023
| @@ -91,8 +91,8 @@ suite(`DotnetTest: ${testAssetWorkspace.description}`, function () { | |||
| const endingPath = 'settings\\TestSettings.runsettings'.replace('\\', path.sep); | |||
| const relativeRunSettingPath = `.\\${endingPath}`.replace('\\', path.sep); | |||
|
|
|||
| const omnisharpConfig = vscode.workspace.getConfiguration('omnisharp'); | |||
| await omnisharpConfig.update('testRunSettings', relativeRunSettingPath); | |||
There was a problem hiding this comment.
Is it possible to have one integration test to cover the test run?
There was a problem hiding this comment.
I'll add one in a followup to cover runsettings - want to make sure this one gets in for the snap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5719 as the final (known) issue.
Server side PR - dotnet/roslyn#69792
Draft until the server side merges and I can add integration test support here.