Fix Auto Insert XML Comment Issue #6130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibarbet
approved these changes
Aug 14, 2023
Co-authored-by: David Barbet <dibarbet@gmail.com>
sharwell
reviewed
Aug 15, 2023
Comment on lines
+864
to
+865
| // The server expects the request position to represent the caret position in the text after the change has already been applied. | ||
| // We need to calculate what that position would be after the change is applied and send that to the server. |
There was a problem hiding this comment.
❔ Can you point me to the public LSP specification documentation for this behavior?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6039